Add workflow_dispatch to generate-query-help-docs.yml#4808
Merged
Conversation
adityasharad
requested changes
Dec 11, 2020
Collaborator
adityasharad
left a comment
adityasharad
left a comment
There was a problem hiding this comment.
Sounds sensible, some simplification possible in the code.
Comment on lines
9
to
12
Collaborator
There was a problem hiding this comment.
You don't need this: ref is already a part of the workflow_dispatch event. To run against the lgtm.com branch, just choose that branch in the dispatch UI.
Suggested change
| ref: | |
| description: The branch in github/codeql to checkout when generating query help. | |
| required: false | |
| default: 'lgtm.com' |
Comment on lines
29
to
35
Collaborator
There was a problem hiding this comment.
Also not needed: if no ref is supplied to actions/checkout, it defaults to github.ref which will come from the dispatch event. The existing code is fine.
Suggested change
| path: codeql | |
| ref: ${{ github.event.inputs.ref }} | |
| - if: github.event.inputs.ref == '' | |
| name: Clone github/codeql (default ref) | |
| uses: actions/checkout@v2 | |
| with: | |
| path: codeql | |
| path: codeql |
adityasharad
approved these changes
Dec 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
workflow_dispatchevent to the workflow for generating the query help documentation, so that we can trigger query help generation manually. I've also removedmainandrc/**from thepushevents because we only really want to run this workflow when upgrading the distribution on lgtm.com.