C++: Add cases in the Allocation model.#4824
Merged
jbj merged 4 commits intogithub:mainfrom Dec 18, 2020
Merged
Conversation
MathiasVP
reviewed
Dec 15, 2020
cpp/ql/src/semmle/code/cpp/models/implementations/Allocation.qll
Outdated
Show resolved
Hide resolved
… of the SysAlloc stuff is beyond our current models, supporting just SysFreeString as we do is OK.
Contributor
Author
|
There was a failing (internal) test and I had to remove support for When we have support for access paths in our models, I think we should be able to do better. |
jbj
approved these changes
Dec 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on the #4783 I noticed a few holes in our allocation models. I've also added test cases for
strdup, a standard library function which it turns out we already support.