JS: support sanitizers that sanitize individual chars in js/shell-commandconstructed-from-input #4921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erik-krogh
added
the
Awaiting evaluation
esbena
reviewed
Jan 6, 2021
Contributor
esbena
left a comment
esbena
left a comment
There was a problem hiding this comment.
LGTM except for a nit, two ideas for future work.
.../ql/src/semmle/javascript/security/dataflow/UnsafeShellCommandConstructionCustomizations.qll
Outdated
Show resolved
Hide resolved
| * Holds if `instance` is an instance of the access-path `ap`, and there exists a guard | ||
| * that ensures that `instance` is not equal to `char`. | ||
| */ | ||
| private predicate blocksCharInAccess(AccessPath ap, string char, Expr instance) { |
Contributor
There was a problem hiding this comment.
If the performance works out, we should try to move this SanitizedChar and blocksCharInAccess to TaintTracking.qll (lets make a separate issue for that).
Contributor
Author
There was a problem hiding this comment.
So generalize the sanitizer such that other queries can use it?
.../ql/src/semmle/javascript/security/dataflow/UnsafeShellCommandConstructionCustomizations.qll
Show resolved
Hide resolved
.../ql/src/semmle/javascript/security/dataflow/UnsafeShellCommandConstructionCustomizations.qll
Show resolved
Hide resolved
…-constructed-from-input
Co-authored-by: Esben Sparre Andreasen <esbena@github.com>
erik-krogh
force-pushed
the
moreShellSan
branch
from
f8d61c9 to
7eab085
Compare
esbena
reviewed
Jan 7, 2021
.../ql/src/semmle/javascript/security/dataflow/UnsafeShellCommandConstructionCustomizations.qll
Outdated
Show resolved
Hide resolved
…ellCommandConstructionCustomizations.qll Co-authored-by: Esben Sparre Andreasen <esbena@github.com>
esbena
approved these changes
Jan 7, 2021
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gets a TN for CVE-2020-26274