C++: Remove @precision from AV Rule 78 #497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This rule, named "No virtual destructor", was supposed to be superseded by `cpp/virtual-destructor` in 0c796de, but that commit didn't actually disable this rule, so both rules are now active in the LGTM suite. This commit disables the rule by removing `@precision`. We're still discussing the best way to disable rules that are precise and valid but not universally applicable. For now, removing `@precision` is consistent with how we're keeping most other JSF queries from appearing on LGTM.
geoffw0
approved these changes
Nov 20, 2018
Contributor
geoffw0
left a comment
geoffw0
left a comment
There was a problem hiding this comment.
I'd suggest turning it down to warning medium, as it looks to be slightly less accurate than the other version of the query - but that would not be enough to disable it on LGTM.
cklin
pushed a commit
that referenced
this pull request
May 23, 2022
Fix performance issue with 'package'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rule, named "No virtual destructor", was supposed to be superseded by
cpp/virtual-destructorin #408, but that PR didn't actually disable this rule, so both rules are now active in the LGTM suite.This PR disables the rule by removing
@precision. We're still discussing the best way to disable rules that are precise and valid but not universally applicable. For now, removing@precisionis consistent with how we're keeping most other JSF queries from appearing on LGTM.