Skip to content

Conversation

@xiemaisi
Copy link

Otherwise alerts for multi-line <a> elements end up looking very red.

I also took the opportunity to improve the tests slightly.

…ink.

Otherwise alerts for multi-line `<a>` elements end up looking very red.

I also took the opportunity to improve the tests slightly.
@xiemaisi xiemaisi added the JS label Nov 20, 2018
@xiemaisi xiemaisi requested a review from a team as a code owner November 20, 2018 12:54
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@semmle-qlci semmle-qlci merged commit b21b066 into github:master Nov 20, 2018
@xiemaisi xiemaisi deleted the js/target-blank-location branch November 28, 2018 09:22
cklin pushed a commit that referenced this pull request May 23, 2022
Extract diagnostic information
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants