Python: model HTTP sink in Tornado #4995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is quite a simpel model, but ends up matching what we were able to do with points-to. I think this modeling excercise really shows that we need a bit of a different way to model HTTP responses... but I'm not going to try to fix that in this PR.
RasmusWL
changed the title
RasmusWL
added a commit
to RasmusWL/codeql
that referenced
this pull request
Jan 21, 2021
After making github#4995, I realized how easy this would be :D Will need to do some manual merge-conflict handling, but it should be all good :)
yoff
approved these changes
Jan 24, 2021
Contributor
yoff
left a comment
yoff
left a comment
There was a problem hiding this comment.
I think this is a clear improvement in our modelling even without self.connection.request.write and can be merged as is.
Contributor
|
I agree that we need a way to handle a fluent api. I would be curious to hear ideas, do we annotate the method itself? Or perhaps the return statement(/last line)? |
Member
Author
I'm thinking to model all content-writes, and header writes separately, and stitching them together. I think Go does something similar to this right now, so I'll definitely want to talk with them before moving on with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is quite a simpel model, but ends up matching what we were able to do with points-to.
I think this modeling excercise really shows that we need a bit of a different way to model HTTP responses... but I'm not going to try to fix that in this PR.