Skip to content

Conversation

@RasmusWL
Copy link
Member

No description provided.

@RasmusWL RasmusWL requested a review from a team as a code owner January 27, 2021 18:12
Copy link
Contributor

@yoff yoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this rely on the user (so far just ourselves) using startInAttr to track foo.bar in import foo.bar?

@RasmusWL
Copy link
Member Author

RasmusWL commented Jan 28, 2021

Does this rely on the user (so far just ourselves) using startInAttr to track foo.bar in import foo.bar?

I don't understand your question. The problem is that import foo.bar will result in foo being added to the current scope (and now you can access the bar attribute of the foo module. With the previous modeling, we said that foo was also a reference to foo.bar, which is obviously wrong 😬

@yoff
Copy link
Contributor

yoff commented Jan 28, 2021

Ah, I see, I did not read the code properly. This seems fine :-)

Copy link
Contributor

@yoff yoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yoff yoff merged commit 1068ede into github:main Jan 28, 2021
@RasmusWL RasmusWL deleted the import-fix branch January 28, 2021 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants