Promote cpp/unsigned-difference-expression-compared-zero out of experimental#5094
Merged
geoffw0 merged 7 commits intoFeb 4, 2021
Merged
Conversation
hubwriter
reviewed
Feb 4, 2021
hubwriter
left a comment
hubwriter
left a comment
Contributor
There was a problem hiding this comment.
LGTM - just a few minor observations.
| @@ -0,0 +1,2 @@ | |||
| lgtm | |||
Contributor
There was a problem hiding this comment.
The other change notes all seem to be lgtm,codescanning.
No codescanning for this?
Contributor
Author
There was a problem hiding this comment.
No. As far as I know, code scanning only runs queries with @precision high, and this one is currently at medium. We hope that this query can be promoted to high precision in the future, but we want to try it out on LGTM first.
Contributor
There was a problem hiding this comment.
That's true by default, but there's alternate suites that are recommended to users that want to run more queries. We might want a separate note for code scanning that mentions the security-extended and security-and-quality suites.
Co-authored-by: hubwriter <hubwriter@github.com>
geoffw0
reviewed
Feb 4, 2021
…thub.com:MathiasVP/ql into promote-UnsignedDifferenceExpressionComparedZero
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the final step of https://github.com/github/codeql-c-analysis-team/issues/210. I didn't promote the query to high precision yet as that's been moved to https://github.com/github/codeql-c-analysis-team/issues/226.