C++: Refactor CWE-497 for clarity and performance #547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Do you want this in 1.19? |
Contributor
Author
|
Good point, we may as well. Retargetted. |
jbj
approved these changes
Nov 26, 2018
cklin
pushed a commit
that referenced
this pull request
May 23, 2022
Performance: Fix bad join ordering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lifts out an intermediate helper predicate that restricts attention to only variables which are somehow affected by potential system data. The restriction existed before, but could be applied too late, meaning that on at least one database (with several very frequently accessed global variables) the query took too long.
Behaviour should be unchanged, and performance improvements have been confirmed on the problematic database.