Python: Query for use of weak crypto keys. #550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taus-semmle
reviewed
Nov 27, 2018
Contributor
taus-semmle
left a comment
taus-semmle
left a comment
There was a problem hiding this comment.
One comment, otherwise LGTM.
| ) | ||
| or | ||
| algorithm = "elliptic curve" and | ||
| mod.getName() = "cryptography.hazmat.primitives.asymmetric.ec" and arg = "curve" |
Contributor
There was a problem hiding this comment.
This disjunct can be deleted.
markshannon
force-pushed
the
python-weak-crypto
branch
from
795c8a1 to
d542824
Compare
markshannon
force-pushed
the
python-weak-crypto
branch
from
d542824 to
b3eaa46
Compare
taus-semmle
previously approved these changes
Nov 28, 2018
Contributor
|
@taus - thanks for telling me about this PR. As far as I can tell, the text is reasonable. |
taus-semmle
approved these changes
Nov 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.