JS: model additional React component methods #607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
December 4, 2018 10:48
ghost
added
the
ghost
self-requested a review
as a 
Author
|
Thanks for picking this up! Yea, it's badges/shields#2441. |
paulmelnikow
reviewed
Dec 4, 2018
Author
|
I have verified that this fixes the FP in badges/shields#2441, and simplified the enclosing file to a regression test. |
xiemaisi
approved these changes
Dec 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for React state/props access through the component methods:
getSnapshotBeforeUpdate,shouldComponentUpdateandgetDerivedStateFromProps. This is in response to https://discuss.lgtm.com/t/props-and-state-access-in-reacts-getderivedstatefromprops-method/1586 (Thanks @paulmelnikow).(Evaluation in progress)
@paulmelnikow, your post does not contain a link to the false positive, can you link it here so I can check that we eliminate it?