JavaScript: fix performance issue in ServerSideUrlRedirect.qll#75
Merged
semmle-qlci merged 1 commit intogithub:masterfrom Aug 20, 2018
Merged
Conversation
aibaars
pushed a commit
that referenced
this pull request
Oct 14, 2021
Add AST classes and tests for operations
erik-krogh
pushed a commit
to erik-krogh/ql
that referenced
this pull request
Dec 15, 2021
Expose transitive closure syntax.
erik-krogh
pushed a commit
to erik-krogh/ql
that referenced
this pull request
Dec 15, 2021
Expose transitive closure syntax.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a performance issue in ServerSideUrlRedirect discovered while switching to the string concatenation library.
I'm fixing this separately in order to have a "fair" perf comparison of string concatenation library.
The problem was that
prefixPredincluded a reordered copy of all of the flow edges and was subsequently used in a negation, causing it to be materialised.Performance results.