JS: Support unknown event handlers in js/unbound-event-handler-receiver#767
Merged
semmle-qlci merged 2 commits intomasterfrom Jan 16, 2019
unknown repository
Merged
JS: Support unknown event handlers in js/unbound-event-handler-receiver#767semmle-qlci merged 2 commits intomasterfrom unknown repository
semmle-qlci merged 2 commits intomasterfrom
unknown repository
Conversation
ghost
self-requested a review
as a 
ghost
changed the title
xiemaisi
approved these changes
Jan 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes this FP which is bound here through
this[ prop ] = this[ prop ].bind( this ).Evaluation on react.slugs eliminates three additional FPs in the same project as above.