Python: Two new queries for URL and hostname sanitization (CWE-020). #820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felicitymay
reviewed
Jan 25, 2019
| </p> | ||
| <p> | ||
| This vulnerability is addressed in the <code>safe</code> check, which | ||
| escapes the <code>.</code> and will reject <code>wwwXexample.com</code>. |
Contributor
There was a problem hiding this comment.
Suggest: "The safe check closes this vulnerability by escaping the . so that URLs of the form wwwXexample.com are rejected."
python/ql/src/Security/CWE-020/IncompleteUrlSubstringSanitization.qhelp
Outdated
Show resolved
Hide resolved
python/ql/src/Security/CWE-020/examples/IncompleteUrlSubstringSanitization.py
Show resolved
Hide resolved
Contributor
|
Thanks for the text updates. The text LGTM now. |
ghost
previously approved these changes
Jan 28, 2019
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
LGTM.
Thanks for updating the JavaScript qhelp as well.
taus-semmle
approved these changes
Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two queries are a re-implementation of https://github.com/Semmle/ql/tree/master/javascript/ql/src/Security/CWE-020 for Python.