Skip to content

InlineExpectationsTest: Allow URLs as values #8530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
RasmusWL wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

InlineExpectationsTest: Allow URLs as values #8530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cpp/ql/test/TestUtilities/InlineExpectationsTest.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,10 +173,10 @@ abstract class InlineExpectationsTest extends string {
/**
* RegEx pattern to match a comment containing one or more expected results. The comment must have
* `$` as its first non-whitespace character. Any subsequent character
* is treated as part of the expected results, except that the comment may contain a `//` sequence
* is treated as part of the expected results, except that the comment may contain a ` //` sequence
* to treat the remainder of the line as a regular (non-interpreted) comment.
*/
private string expectationCommentPattern() { result = "\\s*\\$((?:[^/]|/[^/])*)(?://.*)?" }
private string expectationCommentPattern() { result = "\\s*\\$((?:[^/]|[^ ]//|/[^/])*)(?: //.*)?" }

/**
* The possible columns in an expectation comment. The `TDefaultColumn` branch represents the first
Expand Down
4 changes: 2 additions & 2 deletions csharp/ql/test/TestUtilities/InlineExpectationsTest.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,10 +173,10 @@ abstract class InlineExpectationsTest extends string {
/**
* RegEx pattern to match a comment containing one or more expected results. The comment must have
* `$` as its first non-whitespace character. Any subsequent character
* is treated as part of the expected results, except that the comment may contain a `//` sequence
* is treated as part of the expected results, except that the comment may contain a ` //` sequence
* to treat the remainder of the line as a regular (non-interpreted) comment.
*/
private string expectationCommentPattern() { result = "\\s*\\$((?:[^/]|/[^/])*)(?://.*)?" }
private string expectationCommentPattern() { result = "\\s*\\$((?:[^/]|[^ ]//|/[^/])*)(?: //.*)?" }

/**
* The possible columns in an expectation comment. The `TDefaultColumn` branch represents the first
Expand Down
4 changes: 2 additions & 2 deletions java/ql/test/TestUtilities/InlineExpectationsTest.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,10 +173,10 @@ abstract class InlineExpectationsTest extends string {
/**
* RegEx pattern to match a comment containing one or more expected results. The comment must have
* `$` as its first non-whitespace character. Any subsequent character
* is treated as part of the expected results, except that the comment may contain a `//` sequence
* is treated as part of the expected results, except that the comment may contain a ` //` sequence
* to treat the remainder of the line as a regular (non-interpreted) comment.
*/
private string expectationCommentPattern() { result = "\\s*\\$((?:[^/]|/[^/])*)(?://.*)?" }
private string expectationCommentPattern() { result = "\\s*\\$((?:[^/]|[^ ]//|/[^/])*)(?: //.*)?" }

/**
* The possible columns in an expectation comment. The `TDefaultColumn` branch represents the first
Expand Down
4 changes: 2 additions & 2 deletions python/ql/test/TestUtilities/InlineExpectationsTest.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,10 +173,10 @@ abstract class InlineExpectationsTest extends string {
/**
* RegEx pattern to match a comment containing one or more expected results. The comment must have
* `$` as its first non-whitespace character. Any subsequent character
* is treated as part of the expected results, except that the comment may contain a `//` sequence
* is treated as part of the expected results, except that the comment may contain a ` //` sequence
* to treat the remainder of the line as a regular (non-interpreted) comment.
*/
private string expectationCommentPattern() { result = "\\s*\\$((?:[^/]|/[^/])*)(?://.*)?" }
private string expectationCommentPattern() { result = "\\s*\\$((?:[^/]|[^ ]//|/[^/])*)(?: //.*)?" }

/**
* The possible columns in an expectation comment. The `TDefaultColumn` branch represents the first
Expand Down
4 changes: 2 additions & 2 deletions ruby/ql/test/TestUtilities/InlineExpectationsTest.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,10 +173,10 @@ abstract class InlineExpectationsTest extends string {
/**
* RegEx pattern to match a comment containing one or more expected results. The comment must have
* `$` as its first non-whitespace character. Any subsequent character
* is treated as part of the expected results, except that the comment may contain a `//` sequence
* is treated as part of the expected results, except that the comment may contain a ` //` sequence
* to treat the remainder of the line as a regular (non-interpreted) comment.
*/
private string expectationCommentPattern() { result = "\\s*\\$((?:[^/]|/[^/])*)(?://.*)?" }
private string expectationCommentPattern() { result = "\\s*\\$((?:[^/]|[^ ]//|/[^/])*)(?: //.*)?" }

/**
* The possible columns in an expectation comment. The `TDefaultColumn` branch represents the first
Expand Down