Fix reccomendation for LargeParameter (C++)#865
Merged
rdmarsh2 merged 2 commits intogithub:masterfrom Feb 4, 2019
p-snft:large-parameter-const-reference
Merged
Fix reccomendation for LargeParameter (C++)#865rdmarsh2 merged 2 commits intogithub:masterfrom p-snft:large-parameter-const-reference
rdmarsh2 merged 2 commits intogithub:masterfrom
p-snft:large-parameter-const-reference
Conversation
The previous reccomentation changed the behaviour of the code. A user following the advice might have broken her/his code: With call-by-value, the original parameter is not changed. With a call-by-reference, however, it may be changed. To be sure, nothing breaks by blindly following the advice, suggest to pass a const reference.
|
|
kevinbackhouse
previously approved these changes
Feb 4, 2019
Contributor
kevinbackhouse
left a comment
kevinbackhouse
left a comment
There was a problem hiding this comment.
I agree. It is better to suggest passing by const reference.
Contributor
|
LGTM |
Contributor
|
Thank you for the contribution. I agree that this recommendation is an improvement. The tests failed because they depend on the alert message. I've added a commit to update the expected alert messages. |
jbj
approved these changes
Feb 4, 2019
Contributor
jbj
left a comment
jbj
left a comment
There was a problem hiding this comment.
LGTM, but someone else needs to review my change and merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous reccomentation changed the behaviour of the code.
A user following the advice might have broken her/his code:
With call-by-value, the original parameter is not changed.
With a call-by-reference, however, it may be changed. To be sure,
nothing breaks by blindly following the advice, suggest to pass a
const reference.