JavaScript: Support simple data flow through Electron IPC#936
Merged
semmle-qlci merged 7 commits intogithub:masterfrom Feb 25, 2019
Merged
JavaScript: Support simple data flow through Electron IPC#936semmle-qlci merged 7 commits intogithub:masterfrom
semmle-qlci merged 7 commits intogithub:masterfrom
Conversation
ghost
reviewed
Feb 13, 2019
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Generally LGTM, see comments. Do we want to mention this in the change notes?
ghost
previously approved these changes
Feb 14, 2019
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
LGTM. Waiting for the evalution to finish.
(I still think we should mention the improved model of Electron in the changenotes.)
added 7 commits
February 23, 2019 21:43
…pes when available.
I've eliminated the clumsily worded "client-side code" and "server-side code" distinction, not least because Electron fits neither of those categories.
xiemaisi
force-pushed
the
js/revive-electron-support
branch
from
f7d8309 to
0635e1b
Compare
Author
|
Here is the evaluation (internal link). TLDR: No result changes, and no significant performance regressions except on |
ghost
approved these changes
Feb 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resurrects @rdmarsh2's work in #41 on tracking data flow across Electron IPC calls.
Evaluation is still ongoing, but on
electron-many.slugsandbig-apps.slugsthere were no performance regressions and no result changes, so I thought it might be a good idea to put this up for review now.