Add simple mode for highlighting QL dbschemes#949
Merged
semmle-qlci merged 1 commit intogithub:masterfrom Feb 19, 2019
rneatherway:dbscheme-mode
Merged
Add simple mode for highlighting QL dbschemes#949semmle-qlci merged 1 commit intogithub:masterfrom rneatherway:dbscheme-mode
semmle-qlci merged 1 commit intogithub:masterfrom
rneatherway:dbscheme-mode
Conversation
ghost
suggested changes
Feb 19, 2019
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Should I add the
-baseextension to this as well?
No, the -base suffix is just to distinguish it from the mode I use locally, which have much more functionality (that may be a mistake however, we can change that later).
Contributor
Author
|
As the change is minor, I amended my commit. The |
ghost
approved these changes
Feb 19, 2019
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
LGTM.
I agree that moving the regexes to a separate util file is overkill at the moment.
Contributor
Author
|
Cheers, thanks for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@esben-semmle this is a small addition for editing and viewing dbscheme files.
Should I add the
-baseextension to this as well?