Python: fix a couple of performance issues#950
Merged
taus-semmle merged 2 commits intogithub:masterfrom Feb 19, 2019
Merged
Conversation
taus-semmle
reviewed
Feb 19, 2019
Contributor
taus-semmle
left a comment
taus-semmle
left a comment
There was a problem hiding this comment.
Generally LGTM apart from a few questions.
| ) | ||
| } | ||
|
|
||
| private EssaVariable ssa_variable_for_module_attribute(ImportMemberNode f, PointsToContext context) { |
Contributor
There was a problem hiding this comment.
Should this be pragma[noinline] to prevent the refactoring from being undone?
Contributor
Author
There was a problem hiding this comment.
It isn't undone now. If the optimiser changes and inlines it without slowing down, then it's not a problem.
| } | ||
|
|
||
| /** Maps the caller object/context to callee parameter/context for self in calls to methods */ | ||
| private predicate self_in_method_call(ControlFlowNode obj, PointsToContext caller, ParameterDefinition self, PointsToContext callee) { |
Contributor
There was a problem hiding this comment.
As above, pragma[noinline], perhaps?
| self.isSelf() and | ||
| exists(FunctionObject meth, CallNode call | | ||
| meth.getFunction() = self.getScope() and | ||
| callee.fromCall(call, meth, caller) and |
Contributor
There was a problem hiding this comment.
No method_call(meth, caller, call)? Does the addition of self.isSelf() somehow obviate the need for this?
Contributor
Author
There was a problem hiding this comment.
No, but callee.fromCall(call, meth, caller) does.
taus-semmle
approved these changes
Feb 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two cases of bad join order.