Port ProviderConfig model/token overrides and client startup cleanup fix from reference implementation#164
Draft
Port ProviderConfig model/token overrides and client startup cleanup fix from reference implementation#164
Conversation
- Add modelId, wireModel, maxInputTokens, maxOutputTokens to ProviderConfig - Fix client startup cleanup race: properly destroy CLI process on failure - Add unit tests for new ProviderConfig field serialization - Add E2E tests for provider wire model forwarding - Simplify BYOK identity limitations documentation (per reference impl) Co-authored-by: edburns <75821+edburns@users.noreply.github.com>
…om.xml CLI version, and update scripts/codegen @github/copilot version Co-authored-by: edburns <75821+edburns@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Sync reference implementation with 9 new commits
Port ProviderConfig model/token overrides and client startup cleanup fix from reference implementation
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #398
Before the change?
ProviderConfighad no way to override the model name sent to the provider API or control token limitsCopilotClientleaked the CLI process if startup failed after process launch (e.g., protocol version mismatch)After the change?
ProviderConfiggainsmodelId,wireModel,maxInputTokens,maxOutputTokensfields:CopilotClient.startCoreBody()now destroys the CLI process on partial startup failure, preventing resource leaksReference implementation commits ported:
58cf64d,3c622b9,100390aNot ported (intentionally):
1832d0a,79dc615,08b486d,c9433c4,c9c3648,ad0a9aa— test infrastructure, .NET-specific, or generated code (version synced via finish script).Pull request checklist
mvn spotless:applyhas been run to format the codemvn clean verifypasses locallyDoes this introduce a breaking change?