fix(rust): respond when request handlers panic#2077
Open
hogeheer499-commits wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2053.
The Rust session event loop spawns each inbound JSON-RPC request handler independently. If one of those futures panics, Tokio isolates the panic to that task, but the request receives no response and the caller waits until its own timeout.
This catches unwinds at the request-dispatch boundary and returns JSON-RPC internal error (
-32603) for the affected request. The panic payload is not exposed. It also updates thestop_event_loopdocumentation and tests to reflect the current lifecycle: independently spawned handlers may finish after the parent event loop exits.Regression coverage verifies both the internal-error response and post-loop handler completion.
Tests:
cargo test --no-default-features --features test-support --lib(182 passed)session_test(144 passed, 3 ignored)