dotnet: wait for terminal task status in E2E test - #2192
Conversation
Keep polling until the background task reaches a removable terminal state instead of treating response content as completion. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c70e0ca7-1826-462d-bcdb-d1bb4ef859f1
There was a problem hiding this comment.
Pull request overview
Updates the .NET E2E test to avoid racing ahead before a background agent reaches a final observable state.
Changes:
- Waits for completed, failed, cancelled, or idle task status.
- Preserves existing response, cancellation, removal, and post-removal assertions.
Show a summary per file
| File | Description |
|---|---|
dotnet/test/E2E/RpcTasksAndHandlersE2ETests.cs |
Waits for a stable background-task status before continuing assertions. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
Cross-SDK Consistency Review ✅This PR only modifies Since this is a test-only fix with no changes to the public API surface, there are no cross-SDK consistency concerns. Other SDKs' E2E tests may independently benefit from similar terminal-status polling patterns, but that is not a consistency gap introduced by this PR.
|
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c70e0ca7-1826-462d-bcdb-d1bb4ef859f1
Summary
Completed,Failed,Cancelled, orIdlebefore continuingThis addresses the timing race observed while exercising the SDK from copilot-agent-runtime PR #14162 (run 30674591424, job 91300567129).
Cross-SDK audit
TASK_AGENT_DONEcontent while status could still beRunningCompleted,Failed,Cancelled, orIdle, cancelsIdle, then removesValidation
git diff --checkShould_Start_Background_Agent_And_Report_Task_Detailswith the supported SDK