fix: Java README version stuck at 1.0.5-01; release sed regex can't match numeric qualifiers - #2226
fix: Java README version stuck at 1.0.5-01; release sed regex can't match numeric qualifiers#2226rinceyuan wants to merge 1 commit into
Conversation
…atch numeric qualifiers The qualifier group \(-[a-z]...)\ requires qualifiers to start with a letter. Numeric-only qualifiers like \-01\ don't match, so the Maven snippet was never updated past 1.0.5-01. Fix the regex to accept any alphanumeric qualifier start character: \(-[a-zA-Z0-9][a-zA-Z0-9.-]*)\ Also update the stale README versions to 1.0.6 (latest release). Closes github#2209
|
@microsoft-github-policy-service agree company=Microsoft |
1 similar comment
|
@microsoft-github-policy-service agree company=Microsoft |
|
@SteveSandersonMS Small fix for a stale-version bug in the Java README. The release workflow's sed regex couldn't match numeric qualifiers like -01. Regex widened + README bumped to 1.0.6. |
|
Thanks for tracking down the stale Java version references. The underlying bug is real, but this fix is not safe to merge yet. The widened release regex also matches the Both snapshot examples ended as the release version: Because the first pass consumed There are two other gaps:
Suggested revision: correct every corrupted coordinate in |
|
Also cc @edburns - can you confirm what kind of fix you want here? |
Summary
The Maven install snippet in \java/README.md\ is stuck at \1.0.5-01\ because the release workflow's sed regex can't match numeric-only qualifiers.
Root cause
.github/workflows/java-publish-maven.yml\ line 204-205:
\
\(-[a-z][a-z0-9-]\.[0-9][0-9]\)*
\
Requires qualifier to start with a letter and contain .N. -01\ starts with a digit and has no dot — no match.
Fix
Validation
Tested the new regex against all version formats in the issue:
Closes #2209