Skip to content

[Java] Fix java publish to maven - #2324

Merged
edburns merged 1 commit into
mainfrom
edburns/2323-java-windows-x64-embed-rust-cli-runtime
Aug 12, 2026
Merged

[Java] Fix java publish to maven#2324
edburns merged 1 commit into
mainfrom
edburns/2323-java-windows-x64-embed-rust-cli-runtime

Conversation

@edburns

@edburns edburns commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@edburns
edburns requested a review from a team as a code owner August 12, 2026 23:46
Copilot AI balanced review requested due to automatic review settings August 12, 2026 23:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Narrows Java documentation version updates to the Copilot SDK dependency, preventing unrelated Maven dependencies from being modified.

Changes:

  • Scope Maven version replacement to copilot-sdk-java.
  • Add regression coverage ensuring the JNA version remains unchanged.
Show a summary per file
File Description
java/scripts/update-documentation-versions.sh Targets only Copilot SDK Maven dependencies.
java/scripts/test-update-documentation-versions.sh Tests preservation of unrelated dependency versions.

Review details

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Balanced

@github-actions

Copy link
Copy Markdown
Contributor

SDK Consistency Review ✅

This PR modifies only Java build/release scripts:

  • java/scripts/update-documentation-versions.sh — narrows the version-update regex to target only copilot-sdk-java artifact entries, preventing accidental version bumps of unrelated dependencies (e.g., JNA)
  • java/scripts/test-update-documentation-versions.sh — adds test coverage for the above fix

These are Java-specific release tooling changes with no cross-SDK API surface impact. No consistency issues with other SDK implementations (Node.js, Python, Go, .NET, Rust).

Generated by SDK Consistency Review Agent for #2324 · sonnet46 16 AIC · ⌖ 5.34 AIC · ⊞ 6.6K ·

@edburns
edburns merged commit 4134c5e into main Aug 12, 2026
32 checks passed
@edburns
edburns deleted the edburns/2323-java-windows-x64-embed-rust-cli-runtime branch August 12, 2026 23:55
@edburns
edburns restored the edburns/2323-java-windows-x64-embed-rust-cli-runtime branch August 12, 2026 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants