Skip to content

test(java): skip linux runtime tests on other platforms - #2325

Merged
edburns merged 1 commit into
mainfrom
edburns/2323-java-windows-x64-embed-rust-cli-runtime
Aug 13, 2026
Merged

test(java): skip linux runtime tests on other platforms#2325
edburns merged 1 commit into
mainfrom
edburns/2323-java-windows-x64-embed-rust-cli-runtime

Conversation

@edburns

@edburns edburns commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI balanced review requested due to automatic review settings August 13, 2026 00:03
@edburns
edburns requested a review from a team as a code owner August 13, 2026 00:03
@github-actions

Copy link
Copy Markdown
Contributor

Cross-SDK Consistency Review ✅

This PR modifies only java/sdk/src/test/java/com/github/copilot/ffi/NativeRuntimeLoaderTest.java, adding assumeLinuxX64() guards to skip native-runtime extraction tests on non-Linux/x64 platforms.

No cross-SDK consistency issues found. The change is:

  • Test-only — no public API surface is modified
  • Java-specific by designNativeRuntimeLoader is a Java FFI concern; other SDKs (Node.js, Python, Go, .NET, Rust) load native binaries through their own platform-specific mechanisms and don't share this code path
  • Correctly scoped — the assumption helper is private and self-contained within the test class

Generated by SDK Consistency Review Agent for #2325 · sonnet46 16.8 AIC · ⌖ 8.2 AIC · ⊞ 6.6K ·

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds platform assumptions to Java native-runtime tests using Linux x64 fixtures.

Changes:

  • Skips affected tests on non-Linux-x64 platforms.
  • Adds a shared classifier-based assumption helper.
Show a summary per file
File Description
NativeRuntimeLoaderTest.java Guards Linux fixture-based runtime tests by platform.

Review details

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Balanced

@edburns
edburns merged commit 5c2dec4 into main Aug 13, 2026
37 checks passed
@edburns
edburns deleted the edburns/2323-java-windows-x64-embed-rust-cli-runtime branch August 13, 2026 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants