Fix Java builds with scoped npm registries on macOS - #2338
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Pull request overview
Updates Java test builds for npm registry portability and macOS process execution.
Changes:
- Adds npm registry-related flags to Java build installs.
- Resolves
catthroughPATHin Java tests.
Show a summary per file
| File | Description |
|---|---|
java/sdk/pom.xml |
Adjusts npm install arguments. |
JsonRpcClientTest.java |
Uses PATH-resolved cat. |
CliServerManagerTest.java |
Uses PATH-resolved cat. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Suppressed comments (1)
java/sdk/pom.xml:229
- This flag cannot change which URLs this
npm cireads:npm citreats the existing lockfile as frozen, whileomit-lockfile-registry-resolvedonly controls writing new lockfiles.nodejs/package-lock.jsonstill contains explicit public-registry URLs for the scoped CLI packages (for example, line 704), so a scoped@githubregistry remains bypassed here. Regenerate and commit the lockfile with registryresolvedentries omitted, and persist that generation setting.
<argument>--omit-lockfile-registry-resolved=true</argument>
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Balanced
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Cross-SDK Consistency Review ✅This PR makes two Java-only changes:
Neither change affects the public SDK API or introduces feature asymmetry across languages. No cross-SDK consistency concerns.
|
No description provided.