Skip to content

chore: Filter CI job for dependabot auto-merge#1038

Merged
chiedo merged 2 commits intogithub:mainfrom
nschonni:automerge-dependabot-filtering
Nov 9, 2020
Merged

chore: Filter CI job for dependabot auto-merge#1038
chiedo merged 2 commits intogithub:mainfrom
nschonni:automerge-dependabot-filtering

Conversation

@nschonni
Copy link
Copy Markdown
Contributor

@nschonni nschonni commented Nov 3, 2020

Why:

This job currently fires on all Pull Requests, and not just those that may be submitted by Dependabot

What's being changed:

Filter the paths on the job to those files that Dependabot might touch in the future if the Dependabot config yaml is added to this repo.

Check off the following:

@nschonni nschonni requested a review from a team as a code owner November 3, 2020 19:00
@janiceilene janiceilene added the engineering Will involve Docs Engineering label Nov 4, 2020
@janiceilene
Copy link
Copy Markdown
Contributor

Thanks @nschonni! I'll get this triaged for review 🌟

@chiedo
Copy link
Copy Markdown
Contributor

chiedo commented Nov 5, 2020

@JamesMGreene can you dig in to this one?

Copy link
Copy Markdown
Contributor

@heiskr heiskr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Doesn't entirely avoid running the job as there's other PRs that touch those files, but yeah I'd be surprised if Dependabot went any further than this.

@chiedo chiedo merged commit c104912 into github:main Nov 9, 2020
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 9, 2020

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

@saintcriminal
Copy link
Copy Markdown

ophs!...

@nschonni nschonni deleted the automerge-dependabot-filtering branch November 9, 2020 18:08
jnidzwetzki pushed a commit to jnidzwetzki/docs that referenced this pull request Oct 6, 2022
Co-authored-by: Lana Brindley <github@lanabrindley.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engineering Will involve Docs Engineering

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants