chore: Add title to Merge Notification CI job#1049
Merged
chiedo merged 1 commit intogithub:mainfrom Nov 5, 2020
Merged
Conversation
nschonni
force-pushed
the
merge-notification-job-name
branch
from
550e978 to
8a17d40
Compare
Also switch to repository filtering like other jobs
nschonni
force-pushed
the
merge-notification-job-name
branch
from
8a17d40 to
42ae9e3
Compare
Contributor
Author
|
@chiedo I think this one is pretty straight forward fix, for a minor annoyance 😄 |
chiedo
approved these changes
Nov 5, 2020
Contributor
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. |
jnidzwetzki
pushed a commit
to jnidzwetzki/docs
that referenced
this pull request
Oct 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
On the jobs page, because the workflow doesn't have a name, it just shows as the file name
What's being changed:
Add a
namevalue so that the job will be rendered under that string instead of the file name. Also swapped the testing from testing that if the job is running on a private repo, to compare to the repository name like the other jobsCheck off the following: