-
Notifications
You must be signed in to change notification settings - Fork 65k
Update workflow-syntax-for-github-actions.md #1132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
issue github#825. Under the section jobs.<job_id>.steps.run in the subsection Exit codes and error action preference: Under the bullet point for cmd, the second item starts out "cmd.exe will exit with the error level of the last program it executed, and it will and return the error code to the runner." The second "and" was deleted because it was extraneous. The last sentence in the section jobs.<job_id>.steps.with.entrypoint read "The entrypoint keyword is meant to use with Docker container actions, but you can also use it with JavaScript actions that don't define any inputs." "to use" was changed to "to be used".
|
Thanks so much for opening a PR @JBryceOrtiz 🙌 I'll get this triaged for review! |
|
This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit. |
lucascosti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this fix, @JBryceOrtiz! I'll merge this in when the tests pass 👍
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. |
* updated promscalecli * fixed a typo * added the config file section * Update promscale/cli.md Co-authored-by: Charis <26616127+charislam@users.noreply.github.com> * Update promscale/cli.md Co-authored-by: Charis <26616127+charislam@users.noreply.github.com> * Update promscale/cli.md Co-authored-by: Charis <26616127+charislam@users.noreply.github.com> * Update promscale/cli.md Co-authored-by: Charis <26616127+charislam@users.noreply.github.com> * Update promscale/cli.md Co-authored-by: Charis <26616127+charislam@users.noreply.github.com> * Update promscale/cli.md Co-authored-by: Charis <26616127+charislam@users.noreply.github.com> * Update promscale/cli.md Co-authored-by: Charis <26616127+charislam@users.noreply.github.com> * Update promscale/cli.md Co-authored-by: Charis <26616127+charislam@users.noreply.github.com> * Update promscale/cli.md Co-authored-by: Charis <26616127+charislam@users.noreply.github.com> * added the highlight tag * fixed a typo Co-authored-by: Lana Brindley <github@lanabrindley.com> Co-authored-by: Charis <26616127+charislam@users.noreply.github.com>
issue #825. Under the section jobs.<job_id>.steps.run in the subsection Exit codes and error action preference: Under the bullet point for cmd, the second item starts out "cmd.exe will exit with the error level of the last program it executed, and it will and return the error code to the runner." The second "and" was deleted because it was extraneous.
The last sentence in the section jobs.<job_id>.steps.with.entrypoint read "The entrypoint keyword is meant to use with Docker container actions, but you can also use it with JavaScript actions that don't define any inputs." "to use" was changed to "to be used".
Why:
Under the section jobs.<job_id>.steps.run in the subsection Exit codes and error action preference: Under the bullet point for cmd, the second item starts out "cmd.exe will exit with the error level of the last program it executed, and it will and return the error code to the runner." The second "and" was extraneous and was deleted.
The last sentence in the section jobs.<job_id>.steps.with.entrypoint reads "The entrypoint keyword is meant to use with Docker container actions, but you can also use it with JavaScript actions that don't define any inputs." "to use" was changed to "to be used".
What's being changed:
Under the section jobs.<job_id>.steps.run in the subsection Exit codes and error action preference: Under the bullet point for cmd, the second item starts out "cmd.exe will exit with the error level of the last program it executed, and it will and return the error code to the runner." The second "and" was deleted.
The last sentence in the section jobs.<job_id>.steps.with.entrypoint reads "The entrypoint keyword is meant to use with Docker container actions, but you can also use it with JavaScript actions that don't define any inputs." "to use" was changed to "to be used".
Check off the following: