Skip to content

Conversation

@JBryceOrtiz
Copy link
Contributor

issue #825. Under the section jobs.<job_id>.steps.run in the subsection Exit codes and error action preference: Under the bullet point for cmd, the second item starts out "cmd.exe will exit with the error level of the last program it executed, and it will and return the error code to the runner." The second "and" was deleted because it was extraneous.

The last sentence in the section jobs.<job_id>.steps.with.entrypoint read "The entrypoint keyword is meant to use with Docker container actions, but you can also use it with JavaScript actions that don't define any inputs." "to use" was changed to "to be used".

Why:

Under the section jobs.<job_id>.steps.run in the subsection Exit codes and error action preference: Under the bullet point for cmd, the second item starts out "cmd.exe will exit with the error level of the last program it executed, and it will and return the error code to the runner." The second "and" was extraneous and was deleted.

The last sentence in the section jobs.<job_id>.steps.with.entrypoint reads "The entrypoint keyword is meant to use with Docker container actions, but you can also use it with JavaScript actions that don't define any inputs." "to use" was changed to "to be used".

What's being changed:

Under the section jobs.<job_id>.steps.run in the subsection Exit codes and error action preference: Under the bullet point for cmd, the second item starts out "cmd.exe will exit with the error level of the last program it executed, and it will and return the error code to the runner." The second "and" was deleted.

The last sentence in the section jobs.<job_id>.steps.with.entrypoint reads "The entrypoint keyword is meant to use with Docker container actions, but you can also use it with JavaScript actions that don't define any inputs." "to use" was changed to "to be used".

Check off the following:

issue github#825.  Under the section jobs.<job_id>.steps.run in the subsection Exit codes and error action preference: Under the bullet point for cmd, the second item starts out "cmd.exe will exit with the error level of the last program it executed, and it will and return the error code to the runner." The second "and" was deleted because it was extraneous.

The last sentence in the section jobs.<job_id>.steps.with.entrypoint read "The entrypoint keyword is meant to use with Docker container actions, but you can also use it with JavaScript actions that don't define any inputs." "to use" was changed to "to be used".
@janiceilene
Copy link
Contributor

Thanks so much for opening a PR @JBryceOrtiz 🙌 I'll get this triaged for review!

@janiceilene janiceilene added actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team labels Nov 6, 2020
@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Nov 14, 2020
@lucascosti lucascosti removed the stale There is no recent activity on this issue or pull request label Nov 16, 2020
@lucascosti lucascosti self-assigned this Nov 16, 2020
Copy link
Contributor

@lucascosti lucascosti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix, @JBryceOrtiz! I'll merge this in when the tests pass 👍

@lucascosti lucascosti merged commit d61493f into github:main Nov 16, 2020
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

jnidzwetzki pushed a commit to jnidzwetzki/docs that referenced this pull request Oct 6, 2022
* updated promscalecli

* fixed a typo

* added the config file section

* Update promscale/cli.md

Co-authored-by: Charis <26616127+charislam@users.noreply.github.com>

* Update promscale/cli.md

Co-authored-by: Charis <26616127+charislam@users.noreply.github.com>

* Update promscale/cli.md

Co-authored-by: Charis <26616127+charislam@users.noreply.github.com>

* Update promscale/cli.md

Co-authored-by: Charis <26616127+charislam@users.noreply.github.com>

* Update promscale/cli.md

Co-authored-by: Charis <26616127+charislam@users.noreply.github.com>

* Update promscale/cli.md

Co-authored-by: Charis <26616127+charislam@users.noreply.github.com>

* Update promscale/cli.md

Co-authored-by: Charis <26616127+charislam@users.noreply.github.com>

* Update promscale/cli.md

Co-authored-by: Charis <26616127+charislam@users.noreply.github.com>

* Update promscale/cli.md

Co-authored-by: Charis <26616127+charislam@users.noreply.github.com>

* added the highlight tag

* fixed a typo

Co-authored-by: Lana Brindley <github@lanabrindley.com>
Co-authored-by: Charis <26616127+charislam@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix miscellaneous errors in GitHub Actions / Reference / Workflow syntax

3 participants