Skip to content

Conversation

@stevepiercy
Copy link
Contributor

Why:

Minor grammar correction.

What's being changed:

"other data it will uses" s/b "other data it will use".

Check off the following:

@welcome
Copy link

welcome bot commented Nov 7, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

Copy link
Contributor

@janiceilene janiceilene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for opening a PR and fixing this @stevepiercy! I'll get this branch updated and merge it once the tests are passing 🍏

@janiceilene janiceilene merged commit dbb9b12 into github:main Nov 9, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2020

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

jnidzwetzki pushed a commit to jnidzwetzki/docs that referenced this pull request Oct 6, 2022
* Add first part of time-series vis docs

* Fix linting errors

* Apply suggestions from code review

Co-authored-by: Lana Brindley <github@lanabrindley.com>

* Add raw data example & pre-aggregated data example

* Fix failing linting issues

* Apply suggestions from code review

Co-authored-by: Lana Brindley <github@lanabrindley.com>

* More code review changes

* Apply suggestions from code review + add multi-value graph

* Apply suggestions from code review

Co-authored-by: Charis <26616127+charislam@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Lana Brindley <github@lanabrindley.com>
Co-authored-by: Charis <26616127+charislam@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants