Skip to content

fix: missing paren in link in "Resolving a merge conflict on GitHub"#12009

Merged
ramyaparimi merged 2 commits intogithub:mainfrom
perryprog:missing-paren
Nov 16, 2021
Merged

fix: missing paren in link in "Resolving a merge conflict on GitHub"#12009
ramyaparimi merged 2 commits intogithub:mainfrom
perryprog:missing-paren

Conversation

@perryprog
Copy link
Copy Markdown
Contributor

@perryprog perryprog commented Nov 15, 2021

Why:

Closes #12019

What's being changed:

I've added the missing paren to the markdown's link.

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@welcome
Copy link
Copy Markdown

welcome Bot commented Nov 15, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Nov 15, 2021
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 15, 2021

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Staging Production What Changed
content/pull-requests/collaborating-with-pull-requests/addressing-merge-conflicts/resolving-a-merge-conflict-on-github.md Modified Original

@ramyaparimi ramyaparimi added the invalid This issue/PR is invalid label Nov 15, 2021
@github-actions github-actions Bot closed this Nov 15, 2021
@perryprog
Copy link
Copy Markdown
Contributor Author

perryprog commented Nov 15, 2021

@ramyaparimi, if this was for the missing PR description (and issue), that's my bad—it seems making a PR through GitHub.dev totally bypasses any option to fill out the description. See also the now-linked issue.

Note that I cannot self-review or check the generated content as the staged version is no longer live.

@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team and removed triage Do not begin working on this issue until triaged by the team invalid This issue/PR is invalid labels Nov 16, 2021
@ramyaparimi ramyaparimi reopened this Nov 16, 2021
@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Nov 16, 2021
@ramyaparimi
Copy link
Copy Markdown
Contributor

@perryprog Thanks so much for clarifying ✨ Description and linking issue helps a lot during triaging 💖
The changes LGTM, I will get this merged asap 🍏

@ramyaparimi ramyaparimi added ready to merge This pull request is ready to merge and removed triage Do not begin working on this issue until triaged by the team labels Nov 16, 2021
@ramyaparimi ramyaparimi merged commit 22e9cec into github:main Nov 16, 2021
@github-actions
Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@perryprog perryprog deleted the missing-paren branch November 16, 2021 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Link on "Resolving a merge conflict on GitHub" is broken.

3 participants