Skip to content

Conversation

@highfi13g
Copy link
Contributor

Why:

Need to be more verbose about the requirements. CODESPACES is currently not available for orgs with IP Allow list enabled.

What's being changed:

The current documentation does not state the need to have IP Allow list disabled in order for Codespaces to be visible. I added a line noting this as a requirement to use codespaces within an organization.

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

Need to be more verbose about the requirements. CODESPACES is currently not available for orgs with IP Allow list enabled.
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Nov 23, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 23, 2021

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Staging Production What Changed
content/codespaces/managing-codespaces-for-your-organization/enabling-codespaces-for-your-organization.md Modified Original

@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Nov 23, 2021
@ramyaparimi
Copy link
Contributor

@highfi13g
Thanks so much for opening a PR! I'll get this triaged for review ⚡

Copy link

@pedramgoli pedramgoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

content/codespaces/managing-codespaces-for-your-organization/enabling-codespaces-for-your-organization.md

hubwriter
hubwriter previously approved these changes Nov 26, 2021
Copy link
Contributor

@hubwriter hubwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@highfi13g - Many thanks for making this change. 🙏

I've made a small change, which I'm going to go ahead an apply so that I can get this merged.

Thanks again

@hubwriter hubwriter enabled auto-merge (squash) November 26, 2021 11:07
@hubwriter hubwriter merged commit 6cb4d4a into github:main Nov 26, 2021
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants