Skip to content

Making it easier to understand dependency review for public versus private repos#12454

Merged
mchammer01 merged 4 commits intogithub:mainfrom
NickLiffen:patch-2
Dec 1, 2021
Merged

Making it easier to understand dependency review for public versus private repos#12454
mchammer01 merged 4 commits intogithub:mainfrom
NickLiffen:patch-2

Conversation

@NickLiffen
Copy link
Copy Markdown
Contributor

Why:

Making it easier to understand where Dependency Review is available. This has caused some confusion. Hopefully, the proposed changes make it easier to understand but I welcome feedback 👍

What's being changed:

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Nov 29, 2021
@NickLiffen
Copy link
Copy Markdown
Contributor Author

@jhutchings1 👋 would love your thoughts on this if possible. I can't add you as a reviewer as I don't have write access, but if you could review, that would be amazing 💯

@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Nov 29, 2021
@ramyaparimi
Copy link
Copy Markdown
Contributor

@NickLiffen
Thanks so much for opening a PR! I'll get this triaged for review ⚡

@NickLiffen
Copy link
Copy Markdown
Contributor Author

Thanks, @ramyaparimi 💯 I also welcome someone better at grammar than me to propose changes

For example, another way of maybe phrasing this is:

Dependency review is available for all public repositories, as well as private repositories owned by organizations where ...

I very much welcome feedback on the proposed changes 👍

@mchammer01
Copy link
Copy Markdown
Contributor

@NickLiffen 👋🏻 - I've added jhutchings1 as a reviewer and will make a suggestion on your update 🙂

Comment thread data/reusables/gated-features/dependency-review.md Outdated
Copy link
Copy Markdown
Contributor

@mchammer01 mchammer01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NickLiffen - thanks for suggesting an improvement.
I've added a suggestion, let me know what you think 😃

@mchammer01
Copy link
Copy Markdown
Contributor

mchammer01 commented Dec 1, 2021

@NickLiffen - thank you for highlighting that this sentence was confusing. I hadn't realized until you mentioned it 🤦🏻
Will apply the suggestion and merge this PR.
Thanks again 💖

Copy link
Copy Markdown
Contributor

@mchammer01 mchammer01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨

@mchammer01 mchammer01 enabled auto-merge December 1, 2021 06:02
@mchammer01 mchammer01 merged commit bc4c2a4 into github:main Dec 1, 2021
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 1, 2021

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@NickLiffen NickLiffen deleted the patch-2 branch December 1, 2021 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants