Skip to content

Add missing "pages" GITHUB_TOKEN permissions to list#12606

Merged
ramyaparimi merged 2 commits intogithub:mainfrom
AnilSeervi:add-gh-pages-token-perms
Dec 9, 2021
Merged

Add missing "pages" GITHUB_TOKEN permissions to list#12606
ramyaparimi merged 2 commits intogithub:mainfrom
AnilSeervi:add-gh-pages-token-perms

Conversation

@AnilSeervi
Copy link
Copy Markdown
Contributor

@AnilSeervi AnilSeervi commented Dec 4, 2021

Why:

Closes #12597

What's being changed:

  • Adds Pages GitHub token permissions to list

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Dec 4, 2021
@AnilSeervi
Copy link
Copy Markdown
Contributor Author

AnilSeervi commented Dec 4, 2021 •
edited
Loading

The table on this page - https://docs.github.com/en/actions/security-guides/automatic-token-authentication#permissions-for-the-github_token
is missing pages and discussions properties.

I can add them to the list if someone can provide me with the Default access (permissive), Default access (restricted) and Maximum access by forked repos values for these properties.

@popeomega
Copy link
Copy Markdown

popeomega commented Dec 4, 2021

#12606

@0637554214
Copy link
Copy Markdown

0637554214 commented Dec 4, 2021 via email

@0637554214
Copy link
Copy Markdown

0637554214 commented Dec 4, 2021 via email

@popeomega
Copy link
Copy Markdown

popeomega commented Dec 4, 2021

K

@0637554214
Copy link
Copy Markdown

0637554214 commented Dec 5, 2021 via email

@ramyaparimi ramyaparimi added actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Dec 6, 2021
@ramyaparimi
Copy link
Copy Markdown
Contributor

ramyaparimi commented Dec 6, 2021

@AnilSeervi
Thanks so much for opening a PR! I'll get this triaged for review ⚡

@0637554214

This comment has been minimized.

Sign in to view
@AnilSeervi AnilSeervi changed the title Add missing Pages GITHUB_TOKEN permissions Add missing "pages" GITHUB_TOKEN permissions to list Dec 8, 2021
ramyaparimi
ramyaparimi approved these changes Dec 9, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@ramyaparimi ramyaparimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnilSeervi
Thanks so much for opening a PR with this fix! I'll update the branch and get this merged once tests are passing 🍏

@ramyaparimi ramyaparimi added the ready to merge This pull request is ready to merge label Dec 9, 2021
@ramyaparimi ramyaparimi enabled auto-merge December 9, 2021 14:12
@github-actions github-actions Bot removed the waiting for review Issue/PR is waiting for a writer's review label Dec 9, 2021
@ramyaparimi ramyaparimi merged commit 3c2e931 into github:main Dec 9, 2021
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 9, 2021

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@ethomson ethomson ethomson approved these changes

@ramyaparimi ramyaparimi ramyaparimi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

permissions list is missing value: pages

5 participants

@AnilSeervi @popeomega @0637554214 @ramyaparimi @ethomson