Skip to content

AD LDS & ADAM do not have have userAccountControl attribute present.#12721

Merged
vgrl merged 4 commits intogithub:mainfrom
affrae:patch-2
Dec 9, 2021
Merged

AD LDS & ADAM do not have have userAccountControl attribute present.#12721
vgrl merged 4 commits intogithub:mainfrom
affrae:patch-2

Conversation

@affrae
Copy link
Copy Markdown
Contributor

@affrae affrae commented Dec 7, 2021

Why:

We have a feature when using a LDAP service (and our documentation discusses this) where you can use LDAP Sync with Active Directory (AD) to suspend and unsuspend users from GHES depending on the account status in AD.

However this feature only works if the userAccountControl attribute is present in the the Active Directory schema. For some flavours of AD, such as AD LDS / ADAM, this attribute is not present in a user record, instead the msDS-UserAccountDisabled provides the appropriate data to work from.

This is causing confusion and pain amongst customers who would like to use LDAP Sync and take our documentation to infer that all flavours of Active Directory are supported.

The PR is to update our LDAP Sync docs to clarify that AD LDS & ADAM do not have have userAccountControl attribute present.

What's being changed:

Replace

{% note %}

**Note**: LDAP entries can only be marked as disabled if you use Active Directory and the `userAccountControl` attribute is present and flagged with `ACCOUNTDISABLE`.

{% endnote %}

with

{% note %}

**Note**: LDAP entries can only be marked as disabled if you use Active Directory and the `userAccountControl` attribute is present and flagged with `ACCOUNTDISABLE`. Some variations of Active Directory, such as AD LDS and ADAM, do not have the `userAccountControl` attribute present.

{% endnote %}

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@welcome
Copy link
Copy Markdown

welcome Bot commented Dec 7, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Dec 7, 2021
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 7, 2021

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Staging Production What Changed
content/admin/authentication/authenticating-users-for-your-github-enterprise-server-instance/using-ldap.md Modified Original

@ramyaparimi ramyaparimi added enterprise Content relating to GitHub Enterprise content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Dec 8, 2021
@ramyaparimi
Copy link
Copy Markdown
Contributor

@affrae
Thanks so much for opening a PR! I'll get this triaged for review ⚡

@vgrl vgrl self-assigned this Dec 9, 2021
vgrl
vgrl previously approved these changes Dec 9, 2021
Copy link
Copy Markdown
Contributor

@vgrl vgrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll update the branch and get this merged once tests are passing 🍏

…hub-enterprise-server-instance/using-ldap.md
@vgrl vgrl added the ready to merge This pull request is ready to merge label Dec 9, 2021
Copy link
Copy Markdown
Contributor

@vgrl vgrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vgrl vgrl merged commit 0c0ecce into github:main Dec 9, 2021
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 9, 2021

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content This issue or pull request belongs to the Docs Content team enterprise Content relating to GitHub Enterprise ready to merge This pull request is ready to merge waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants