Skip to content

Remove line-breaks between rows to fix eerie rendering#13179

Merged
ramyaparimi merged 2 commits intogithub:mainfrom
AnilSeervi:table-row-rendering
Dec 20, 2021
Merged

Remove line-breaks between rows to fix eerie rendering#13179
ramyaparimi merged 2 commits intogithub:mainfrom
AnilSeervi:table-row-rendering

Conversation

@AnilSeervi
Copy link
Copy Markdown
Contributor

@AnilSeervi AnilSeervi commented Dec 19, 2021

Why:

Closes #13178

What's being changed:

  • Removes line-breaks between table-rows to try fix issue.

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 19, 2021

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Staging Production What Changed
content/search-github/searching-on-github/searching-commits.md Modified Original

@Termuxtnt

This comment has been minimized.

Copy link
Copy Markdown
Contributor

@ramyaparimi ramyaparimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnilSeervi
Thanks so much for opening a PR with this fix! I'll get this merged once tests are passing 🍏

@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge labels Dec 20, 2021
@ramyaparimi ramyaparimi merged commit 4ab6399 into github:main Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unexpected rendering of a table-row outside the Table

3 participants