Skip to content

docs: fix whitespace templating issue in github table#15854

Merged
mchammer01 merged 2 commits intogithub:mainfrom
Ameausoone:patch-2
Mar 1, 2022
Merged

docs: fix whitespace templating issue in github table#15854
mchammer01 merged 2 commits intogithub:mainfrom
Ameausoone:patch-2

Conversation

@Ameausoone
Copy link
Copy Markdown
Contributor

@Ameausoone Ameausoone commented Feb 25, 2022

Why:

Fix issue on this page https://docs.github.com/en/actions/learn-github-actions/contexts#github-context
The github template is not well rendered.

image

What's being changed:

Just table templating rendering

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@welcome
Copy link
Copy Markdown

welcome Bot commented Feb 25, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Feb 25, 2022
@ramyaparimi ramyaparimi added actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Feb 28, 2022
@ramyaparimi
Copy link
Copy Markdown
Contributor

@Ameausoone
Thanks so much for opening a PR! I'll get this triaged for review ⚡

@ramyaparimi ramyaparimi linked an issue Feb 28, 2022 that may be closed by this pull request
1 task
Copy link
Copy Markdown
Contributor

@mchammer01 mchammer01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ameausoone - thanks for fixing the bad rendering on the table, LGTM ✨

@mchammer01 mchammer01 enabled auto-merge March 1, 2022 08:53
@mchammer01 mchammer01 added ready to merge This pull request is ready to merge and removed waiting for review Issue/PR is waiting for a writer's review labels Mar 1, 2022
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 1, 2022

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
content/actions/learn-github-actions/contexts.md Modified Original

@mchammer01 mchammer01 merged commit da91211 into github:main Mar 1, 2022
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 1, 2022

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@Ameausoone Ameausoone deleted the patch-2 branch March 2, 2022 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing whitespace control char breaks table rendering

3 participants