Skip to content

Fix wrong component name#17154

Merged
lecoursen merged 2 commits intogithub:mainfrom
hong9lol:patch-3
Apr 18, 2022
Merged

Fix wrong component name#17154
lecoursen merged 2 commits intogithub:mainfrom
hong9lol:patch-3

Conversation

@hong9lol
Copy link
Copy Markdown
Contributor

@hong9lol hong9lol commented Apr 17, 2022

Why:

  • The hashtag doesn't work due to wong component name "job"
  • It should be "workflow"

What's being changed:

  • Change the component name "job" to "workflow" in the sentence

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

- the hashtag doesn't work
- change the component name "job" to "workflow"
@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Apr 17, 2022
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 17, 2022

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
content/actions/learn-github-actions/understanding-github-actions.md Modified Original

@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review needs SME This proposal needs review from a subject matter expert and removed triage Do not begin working on this issue until triaged by the team labels Apr 18, 2022
@github-actions
Copy link
Copy Markdown
Contributor

Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀

Copy link
Copy Markdown
Member

@lecoursen lecoursen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lecoursen lecoursen enabled auto-merge April 18, 2022 14:21
@lecoursen lecoursen merged commit 2884703 into github:main Apr 18, 2022
@github-actions
Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@hong9lol hong9lol deleted the patch-3 branch May 19, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team needs SME This proposal needs review from a subject matter expert waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants