Remove inline "position:sticky" from "header".#17306
Closed
jaredasutton wants to merge 1 commit intogithub:mainfrom
jaredasutton:patch-2
Closed
Remove inline "position:sticky" from "header".#17306jaredasutton wants to merge 1 commit intogithub:mainfrom jaredasutton:patch-2
jaredasutton wants to merge 1 commit intogithub:mainfrom
jaredasutton:patch-2
Conversation
Using "position:sticky" on both the component root element and the header element causes the header element to move down the page as the user scrolls down.
|
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Contributor
|
Hey @jaredasutton thanks for submitting this! What timing - we have a PR that's being merged now to fix this! I'll close this for now. If you don't see the update in the next hour or so, please reopen! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
Using "position:sticky" on both the component root element and the header element causes the header element to move down the page as the user scrolls down.
What's being changed:
Only the component root element will have "position:sticky."

Check off the following:
Writer impact (This section is for GitHub staff members only):