Skip to content

Remove inline "position:sticky" from "header".#17306

Closed
jaredasutton wants to merge 1 commit intogithub:mainfrom
jaredasutton:patch-2
Closed

Remove inline "position:sticky" from "header".#17306
jaredasutton wants to merge 1 commit intogithub:mainfrom
jaredasutton:patch-2

Conversation

@jaredasutton
Copy link
Copy Markdown

Why:

Using "position:sticky" on both the component root element and the header element causes the header element to move down the page as the user scrolls down.

Image from Gyazo

What's being changed:

Only the component root element will have "position:sticky."
Image from Gyazo

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

Using "position:sticky" on both the component root element and the header element causes the header element to move down the page as the user scrolls down.
@jaredasutton jaredasutton requested a review from a team as a code owner April 22, 2022 21:25
@welcome
Copy link
Copy Markdown

welcome Bot commented Apr 22, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Apr 22, 2022
@gracepark
Copy link
Copy Markdown
Contributor

Hey @jaredasutton thanks for submitting this! What timing - we have a PR that's being merged now to fix this! I'll close this for now. If you don't see the update in the next hour or so, please reopen!

@gracepark gracepark closed this Apr 22, 2022
@jaredasutton jaredasutton deleted the patch-2 branch April 22, 2022 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

triage Do not begin working on this issue until triaged by the team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants