Skip to content

Indicate correct Ruby version to install#17505

Closed
bewuethr wants to merge 2 commits intogithub:mainfrom
bewuethr:patch-2
Closed

Indicate correct Ruby version to install#17505
bewuethr wants to merge 2 commits intogithub:mainfrom
bewuethr:patch-2

Conversation

@bewuethr
Copy link
Copy Markdown

@bewuethr bewuethr commented Apr 30, 2022

Why:

Closes #17504

What's being changed:

Clarify the Ruby version to install to get Jekyll with the github-pages gem to build locally. This change is in a reusable snippet, used both in content/pages/setting-up-a-github-pages-site-with-jekyll/creating-a-github-pages-site-with-jekyll.md and content/pages/setting-up-a-github-pages-site-with-jekyll/testing-your-github-pages-site-locally-with-jekyll.md.

In both places, the current content is

image

and with the suggested change

image

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@welcome
Copy link
Copy Markdown

welcome Bot commented Apr 30, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Apr 30, 2022
@github-actions
Copy link
Copy Markdown
Contributor

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
content/pages/setting-up-a-github-pages-site-with-jekyll/creating-a-github-pages-site-with-jekyll.md Modified Original

@bewuethr bewuethr marked this pull request as draft April 30, 2022 20:23
@bewuethr bewuethr marked this pull request as ready for review April 30, 2022 20:46
@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review pages Content related to GitHub Pages and removed triage Do not begin working on this issue until triaged by the team labels May 3, 2022
@ramyaparimi
Copy link
Copy Markdown
Contributor

@bewuethr
Thanks so much for opening a PR! I'll get this triaged for review ⚡

@guntrip
Copy link
Copy Markdown
Contributor

guntrip commented May 31, 2022

Hi @bewuethr! 👋 In the time since you opened this, it looks like the github-pages gem now supports Ruby 3.x. I'd suggest opening an issue on the pages-gem repository if you're still having trouble.

As this seems resolved now, I'm going to close this PR and the associated issue. Thank you for taking the time to open this! ✨

@guntrip guntrip closed this May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content This issue or pull request belongs to the Docs Content team pages Content related to GitHub Pages waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Instructions to create a GH Pages site with Jekyll should indicate Ruby version

3 participants