Skip to content

Conversation

@gsrohde
Copy link
Contributor

@gsrohde gsrohde commented Jun 3, 2022

Why:

Closes #18419.

What's being changed:

Some of the notes on the Events that trigger workflows page (https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows) are being changed so that instead of reading "By default, all activity types trigger a workflow to run," they read "By default, all activity types trigger workflows that run on this event." (See the issue for details.)

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jun 3, 2022
@cmwilson21 cmwilson21 linked an issue Jun 6, 2022 that may be closed by this pull request
1 task
@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Jun 6, 2022
@cmwilson21
Copy link
Contributor

@gsrohde Thanks so much for opening a PR! I'll get this triaged for review ⚡

I updated your OP to link the issue to your pull request. Check out this article for more details.

@cmwilson21 cmwilson21 added the actions This issue or pull request should be reviewed by the docs actions team label Jun 6, 2022
Copy link
Contributor

@lucascosti lucascosti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @gsrohde. This clarification looks good to me.

@lucascosti lucascosti enabled auto-merge (squash) June 14, 2022 05:51
@lucascosti lucascosti merged commit b36b511 into github:main Jun 14, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unclear notes about which activities for which events trigger workflows

4 participants