Skip to content

Conversation

@ValentinnDimitroff
Copy link

@ValentinnDimitroff ValentinnDimitroff commented Jul 6, 2022

Why:

The name of the token seems wrong as the original key results always in error saying it cannot find a token inside the workflow. This example is not reproducible.

Discussed here

What's being changed (if available, include any code snippets, screenshots, or gifs):

Changing the NODE_AUTH_TOKEN to NPM_AUTH_TOKEN logs in the workflow successfully.

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

The name of the token seems wrong as the original key results always in error saying it cannot find a token.

Changing the `NODE_AUTH_TOKEN` to `NPM_AUTH_TOKEN` fixes the issue.
@welcome
Copy link

welcome bot commented Jul 6, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jul 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2022

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/publishing-packages/publishing-nodejs-packages.md fpt
ghec
ghes@ 3.5 3.4 3.3 3.2 3.1
ghae
fpt
ghec
ghes@ 3.5 3.4 3.3 3.2 3.1
ghae

@cmwilson21
Copy link
Contributor

@ValentinnDimitroff Thanks so much for opening a PR! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Jul 6, 2022
@martin389 martin389 added the needs SME This proposal needs review from a subject matter expert label Jul 12, 2022
@github-actions
Copy link
Contributor

Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀

@github-actions
Copy link
Contributor

This is a gentle bump for the docs team that this PR is waiting for technical review.

@github-actions github-actions bot added the SME stale The request for an SME has staled label Jul 19, 2022
@cmwilson21 cmwilson21 removed the SME stale The request for an SME has staled label Jul 20, 2022
@github-actions
Copy link
Contributor

This is a gentle bump for the docs team that this PR is waiting for technical review.

@github-actions github-actions bot added the SME stale The request for an SME has staled label Jul 27, 2022
@cmwilson21 cmwilson21 removed the SME stale The request for an SME has staled label Jul 28, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2022

This is a gentle bump for the docs team that this PR is waiting for technical review.

@github-actions github-actions bot added the SME stale The request for an SME has staled label Aug 7, 2022
@cmwilson21 cmwilson21 added SME reviewed An SME has reviewed this issue/PR and removed SME stale The request for an SME has staled needs SME This proposal needs review from a subject matter expert labels Aug 8, 2022
@cmwilson21
Copy link
Contributor

Thanks again for opening a PR! I've spoken with the team and can confirm that NODE_AUTH_TOKEN is what's used in actions/setup-node and will be closing this PR.

Check out Publish to npmjs and GPR with npm for more information.

Thank you for your interest in improving GitHub Docs! 💖

@cmwilson21 cmwilson21 closed this Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team SME reviewed An SME has reviewed this issue/PR waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants