Skip to content

Update githubs-products.md#18985

Closed
Bigthinz wants to merge 1 commit intogithub:mainfrom
Bigthinz:patch-2
Closed

Update githubs-products.md#18985
Bigthinz wants to merge 1 commit intogithub:mainfrom
Bigthinz:patch-2

Conversation

@Bigthinz
Copy link
Copy Markdown

Why:

Closes [issue link]

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@welcome
Copy link
Copy Markdown

welcome Bot commented Jul 12, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Jul 12, 2022
@github-actions
Copy link
Copy Markdown
Contributor

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
get-started/learning-about-github/githubs-products.md fpt
ghec
ghes@ 3.5 3.4 3.3 3.2
ghae
fpt
ghec
ghes@ 3.5 3.4 3.3 3.2
ghae

@cmwilson21
Copy link
Copy Markdown
Contributor

@Bigthinz Thanks for opening a PR! ⚡

Per GitHub's content style guide pertaining to lists, we only add the closing period if the list item includes a complete sentence - such as some of the other items in that same list that include a "For more information" link. So we won't be accepting this change.

Please take a look at our help wanted section to find open issues you can work on. ⚡

Thanks for your passion for improving GitHub Docs! 💖

@cmwilson21 cmwilson21 closed this Jul 13, 2022
@cmwilson21 cmwilson21 removed the triage Do not begin working on this issue until triaged by the team label Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants