Skip to content

Fix grammar#19031

Merged
mchammer01 merged 2 commits intogithub:mainfrom
asztalosdani:patch-2
Jul 18, 2022
Merged

Fix grammar#19031
mchammer01 merged 2 commits intogithub:mainfrom
asztalosdani:patch-2

Conversation

@asztalosdani
Copy link
Copy Markdown
Contributor

@asztalosdani asztalosdani commented Jul 15, 2022

Why:

There was a grammar mistake in the strategy/matrix docs.

What's being changed (if available, include any code snippets, screenshots, or gifs):

Chaging that are based the combinations of the variables to that are based ON the combinations of the variables.

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@welcome
Copy link
Copy Markdown

welcome Bot commented Jul 15, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Jul 15, 2022
@cmwilson21
Copy link
Copy Markdown
Contributor

@asztalosdani Thanks so much for opening a PR! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review actions This issue or pull request should be reviewed by the docs actions team and removed triage Do not begin working on this issue until triaged by the team labels Jul 15, 2022
Copy link
Copy Markdown
Contributor

@mchammer01 mchammer01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asztalosdani - thanks for spotting this and fixing it ✨
LGTM 💖

@mchammer01 mchammer01 added the ready to merge This pull request is ready to merge label Jul 18, 2022
@mchammer01 mchammer01 enabled auto-merge July 18, 2022 07:14
@mchammer01 mchammer01 merged commit 36f0713 into github:main Jul 18, 2022
@github-actions
Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants