Skip to content

Conversation

@shekhar-chauhan
Copy link

@shekhar-chauhan shekhar-chauhan commented Jul 19, 2022

Why:

Closes [issue link]

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@welcome
Copy link

welcome bot commented Jul 19, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jul 19, 2022
@github-actions
Copy link
Contributor

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
authentication/managing-commit-signature-verification/signing-commits.md fpt
ghec
ghes@ 3.5 3.4 3.3 3.2
ghae
fpt
ghec
ghes@ 3.5 3.4 3.3 3.2
ghae

@cmwilson21
Copy link
Contributor

@shekhar-chauhan Thanks for opening a pull request! ⚡

The capitalization is correct in this case, so we will be leaving the docs as is. I'll go ahead and close this PR.

Take a look at the contributing.md to learn how to contribute in this repo. You can open a discussion if you have any questions or check out issues with the help wanted label. ✨

Thank you for your interest in improving GitHub Docs! 💖

@cmwilson21 cmwilson21 closed this Jul 19, 2022
@shekhar-chauhan
Copy link
Author

@cmwilson21 but i was working on a repo, and for me, it was failing with a -S and worked fine with a -s

@cmwilson21
Copy link
Contributor

@shekhar-chauhan Thanks for providing this extra information. Per official git documentation, both the -s (sign-off) and -S (signature) flags work on commit messages. The -S flag fits the signature article. 👍

Thanks again for your interest in improving the GitHub Docs! 💛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

triage Do not begin working on this issue until triaged by the team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants