Skip to content

Conversation

@joel-coffman
Copy link

@joel-coffman joel-coffman commented Jul 27, 2022

The education benefits request no longer has a way to upload proof of
academic status -- just taking a picture using the computer's camera.
Thus, this change removes the reference to uploading an image in the
documentation for applying for an educator discount.

Why:

Closes #19342

What's being changed (if available, include any code snippets, screenshots, or gifs):

The instructions for applying for an educator or researcher discount references a way to upload proof of academic status, but the (current) form does not have this button -- just the ability to take a picture using the computer's camera.

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

The education benefits request no longer has a way to upload proof of
academic status -- just taking a picture using the computer's camera.
Thus, this change removes the reference to uploading an image in the
documentation for applying for an educator discount.
@welcome
Copy link

welcome bot commented Jul 27, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jul 27, 2022
@cmwilson21
Copy link
Contributor

@joel-coffman Thanks for opening a pull request and linking it to your issue! ⚡

I'll get this triaged for review ✨

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review education Content related to GitHub Education and removed triage Do not begin working on this issue until triaged by the team labels Jul 28, 2022
@cmwilson21 cmwilson21 added the needs SME This proposal needs review from a subject matter expert label Aug 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2022

Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀

Copy link

@Chardelyce Chardelyce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cmwilson21
Copy link
Contributor

@joel-coffman - Sorry for the delay here. We have been tracking this and working on other updates internally. We have an internal PR in the works that should update this, so I'm going to go ahead and close this PR now. 💛

Please take a look at our help wanted section to find open issues you can work on.

Thank you for your passion and interest in improving GitHub Docs! 💖

@joel-coffman
Copy link
Author

@joel-coffman - Sorry for the delay here. We have been tracking this and working on other updates internally. We have an internal PR in the works that should update this, so I'm going to go ahead and close this PR now. 💛

Thanks for the update, @cmwilson21!

For my own future reference, what kind of contributions does GitHub accept / is GitHub interested in when it comes to documentation? I've submitted a handful of issues and offered to contribute changes, but the response usually seems to be that they'll be addressed internally. While it didn't take a great deal of time to create this pull request, I don't really want to do that if GitHub prefers to resolve these issues on its own. Should I wait for the "help wanted" tag to be applied to an issue before working on it in the future?

@cmwilson21
Copy link
Contributor

@joel-coffman - Great question! We are interested in all contributions that improve our docs! I can't speak for the others you may have submitted, but this one comes down to timing. The team in charge over education and the application process has been rolling out updates behind the scenes and have been gradually updating the docs in the process. I wasn't sure when this update would take place so I left this PR open for tracking. I'm sorry. That's on me. I could have better communicated that.

We understand that our contributors take time out of their day to submit these PRs and issues. We truly appreciate our community's involvement and enthusiasm for helping maintain the docs. We encourage all our users to contribute when they see something that could be updated. Opening an issue before a PR does give our team a chance to review the issue and confirm it or decide if it is best handled internally. In the mean time, the help wanted board is a fantastic place to work on open issues that have already been approved. ✅

Thank you, again, for your interest in contributing, and thank you for opening up this conversation and asking these questions. We look forward to seeing future contributions from you! 💖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content This issue or pull request belongs to the Docs Content team education Content related to GitHub Education needs SME This proposal needs review from a subject matter expert waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No way to upload proof of academic status for education benefits

3 participants