Skip to content

Add actions performance testing numbers for GHES 3.6 #19675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Aug 16, 2022
Merged

Add actions performance testing numbers for GHES 3.6 #19675

merged 13 commits into from
Aug 16, 2022

Conversation

@bquantump
Copy link
Contributor

@bquantump bquantump commented Aug 11, 2022 •
edited by cmwilson21
Loading

Why:

Closes 19671

What's being changed (if available, include any code snippets, screenshots, or gifs):

image

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@welcome
Copy link

welcome bot commented Aug 11, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Aug 11, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 11, 2022 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
admin/github-actions/getting-started-with-github-actions-for-your-enterprise/getting-started-with-github-actions-for-github-enterprise-server.md ghes@ 3.6 3.5 3.4 3.3 3.2
ghes@ 3.6 3.5 3.4 3.3 3.2

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@bquantump
Copy link
Contributor Author

bquantump commented Aug 11, 2022

@brcrista @GitLofquist

@cmwilson21
Copy link
Contributor

cmwilson21 commented Aug 11, 2022

👋 @bquantump. I just made a tiny edit in the original post so that it links with the issue you opened. Since this is still a draft, I'll hold off on triaging it until you are ready for our team to review. ⚡

Thank you! 💛

bquantump and others added 3 commits August 11, 2022 13:17
@bquantump @brcrista
Update content/admin/github-actions/getting-started-with-github-actio…
ad0be25 
…ns-for-your-enterprise/getting-started-with-github-actions-for-github-enterprise-server.md


Code review suggestion

Co-authored-by: Brian Cristante <33549821+brcrista@users.noreply.github.com>
@bquantump @brcrista
Update content/admin/github-actions/getting-started-with-github-actio…
a0b98c3 
…ns-for-your-enterprise/getting-started-with-github-actions-for-github-enterprise-server.md

Co-authored-by: Brian Cristante <33549821+brcrista@users.noreply.github.com>
@bquantump
Add setence on performance in regards to connected runners
b433045
@bquantump bquantump marked this pull request as ready for review August 12, 2022 00:16
@bquantump
Copy link
Contributor Author

bquantump commented Aug 12, 2022

@cmwilson21
Ready for review 😃

@cmwilson21
Copy link
Contributor

cmwilson21 commented Aug 12, 2022

Thanks @bquantump! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team enterprise Content relating to GitHub Enterprise waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Aug 12, 2022
@bquantump bquantump changed the title Add actions performance testing numbers for GHEE 3.6 Add actions performance testing numbers for GHES 3.6 Aug 15, 2022
@bquantump
Copy link
Contributor Author

bquantump commented Aug 15, 2022

@cmwilson21 any update?

mattpollard
mattpollard previously approved these changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@mattpollard mattpollard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these updates, @bquantump and @brcrista 🙏🏻 I'll incorporate a small change and then go ahead and merge this. I see some opportunities to refactor this section to make it easier to maintain, and I'll create an internal follow-up issue to track that work.

@mattpollard mattpollard enabled auto-merge August 16, 2022 16:00
@mattpollard mattpollard merged commit dcac8ea into github:main Aug 16, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 16, 2022

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@bquantump bquantump deleted the add-actions-performance-testing-numbers-ghes36 branch August 16, 2022 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@brcrista brcrista brcrista left review comments

@mattpollard mattpollard mattpollard approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team enterprise Content relating to GitHub Enterprise waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add GHES 3.6 Performance Numbers

5 participants

@bquantump @cmwilson21 @mattpollard @brcrista @docubot