Skip to content

Conversation

@gitstua
Copy link
Contributor

@gitstua gitstua commented Sep 23, 2022

After discussions in GHAE channel with @pevd950 I believe we should update the documentation to clarify our guidance for GHAE matches that for GHEC

Why:

Closes #20810

What's being changed (if available, include any code snippets, screenshots, or gifs):

Include text currently showing as below to the documentation for AE for clarity
image

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

After discussions in GHAE channel with @pevd950 I believe we should update the documentation to clarify our guidance for GHAE matches that for GHEC
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Sep 23, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 23, 2022

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
repositories/working-with-files/managing-large-files/about-large-files-on-github.md fpt
ghec
ghes@ 3.6 3.5 3.4 3.3 3.2
ghae
fpt
ghec
ghes@ 3.6 3.5 3.4 3.3 3.2
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@gitstua
Copy link
Contributor Author

gitstua commented Sep 24, 2022

@cmwilson21
Copy link
Contributor

👋 @gitstua - Thank you for opening a PR and linking it to your issue! ✨

I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review repositories Content related to repositories and removed triage Do not begin working on this issue until triaged by the team labels Sep 26, 2022
@lecoursen lecoursen added the enterprise Content relating to GitHub Enterprise label Sep 26, 2022
@jc-clark jc-clark self-requested a review September 27, 2022 16:46
Copy link
Contributor

@jc-clark jc-clark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ This looks great @gitstua, thank you! I added one suggestion for including the more specific on-disk limitation for GHAE inline. Once we get a gut check on that information, I think this will be good to merge.

…bout-large-files-on-github.md

Co-authored-by: Matt Pollard <mattpollard@users.noreply.github.com>
@jc-clark jc-clark enabled auto-merge October 4, 2022 20:51
@jc-clark jc-clark merged commit 1e5edf1 into github:main Oct 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2022

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content This issue or pull request belongs to the Docs Content team enterprise Content relating to GitHub Enterprise repositories Content related to repositories waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AE documentation should be clarified to include repo size limits

5 participants