Skip to content

Update connecting-to-a-private-network.md#22744

Merged
cmwilson21 merged 2 commits intogithub:mainfrom
jlaxson:patch-1
Jan 3, 2023
Merged

Update connecting-to-a-private-network.md#22744
cmwilson21 merged 2 commits intogithub:mainfrom
jlaxson:patch-1

Conversation

@jlaxson
Copy link
Copy Markdown
Contributor

@jlaxson jlaxson commented Dec 16, 2022

Typo It's

Why:

Closes ISSUE

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@welcome
Copy link
Copy Markdown

welcome Bot commented Dec 16, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Dec 16, 2022
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 16, 2022 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/using-github-hosted-runners/connecting-to-a-private-network.md fpt
ghec
ghes@ 3.7 3.6 3.5 3.4 3.3
fpt
ghec
ghes@ 3.7 3.6 3.5 3.4 3.3

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21
Copy link
Copy Markdown
Contributor

cmwilson21 commented Dec 19, 2022

@jlaxson Great catch. Thanks for submitting a PR! I'll get this approved. The repo is frozen for the holidays, but I'll get this merged down once the freeze lifts 🥶

We appreciate your patience during the holidays! ✨

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team and removed triage Do not begin working on this issue until triaged by the team labels Dec 19, 2022
cmwilson21
cmwilson21 approved these changes Dec 19, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@cmwilson21 cmwilson21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great catch!

@cmwilson21 cmwilson21 added ready to merge This pull request is ready to merge Merge-after-freeze labels Dec 19, 2022
Eshmove69
Eshmove69 reviewed Dec 21, 2022
View reviewed changes
Copy link
Copy Markdown

@Eshmove69 Eshmove69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Y

Comment thread content/actions/using-github-hosted-runners/connecting-to-a-private-network.md

Tailscale is a commercial product built on top of WireGuard. This option is very similar to WireGuard, except Tailscale is more of a complete product experience instead of an open source component.

It's disadvantages are similar to WireGuard: The connection is one-to-one, so you might need to do additional work for high availability or high throughput. You still need to generate and securely store keys. The protocol is still UDP, so your network must support UDP traffic.

This comment was marked as spam.

Sign in to view

Comment thread content/actions/using-github-hosted-runners/connecting-to-a-private-network.md
Tailscale is a commercial product built on top of WireGuard. This option is very similar to WireGuard, except Tailscale is more of a complete product experience instead of an open source component.

It's disadvantages are similar to WireGuard: The connection is one-to-one, so you might need to do additional work for high availability or high throughput. You still need to generate and securely store keys. The protocol is still UDP, so your network must support UDP traffic.
Its disadvantages are similar to WireGuard: The connection is one-to-one, so you might need to do additional work for high availability or high throughput. You still need to generate and securely store keys. The protocol is still UDP, so your network must support UDP traffic.

This comment was marked as spam.

Sign in to view

@cklim483 cklim483 mentioned this pull request Dec 22, 2022
Open
@cmwilson21 cmwilson21 enabled auto-merge January 3, 2023 23:44
@cmwilson21 cmwilson21 merged commit 276153b into github:main Jan 3, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 3, 2023

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@Eshmove69 Eshmove69 Eshmove69 left review comments

@cmwilson21 cmwilson21 cmwilson21 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jlaxson @cmwilson21 @Eshmove69 @docubot