Skip to content

Specify PUBLIC key in step 7#22911

Merged
sophietheking merged 3 commits intogithub:mainfrom
gitsmug:patch-1
Jan 27, 2023
Merged

Specify PUBLIC key in step 7#22911
sophietheking merged 3 commits intogithub:mainfrom
gitsmug:patch-1

Conversation

@gitsmug
Copy link
Copy Markdown
Contributor

@gitsmug gitsmug commented Dec 31, 2022

Why:

It's important that we supply GitHub with the public key. Therefore, let's include the word "public" in step 7.

What's being changed:

Update text in step 7 to clearly indicate public key.

(https://docs.github.com/en/authentication/connecting-to-github-with-ssh/adding-a-new-ssh-key-to-your-github-account)

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@welcome
Copy link
Copy Markdown

welcome Bot commented Dec 31, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Dec 31, 2022
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 31, 2022

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
authentication/connecting-to-github-with-ssh/adding-a-new-ssh-key-to-your-github-account.md fpt
ghec
ghes@ 3.7 3.6 3.5 3.4 3.3
ghae
fpt
ghec
ghes@ 3.7 3.6 3.5 3.4 3.3
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review authentication Content relating to authentication and removed triage Do not begin working on this issue until triaged by the team labels Jan 4, 2023
@cmwilson21
Copy link
Copy Markdown
Contributor

@gitsmug Thanks so much for opening a PR! I'll get this triaged for review ⚡

Copy link
Copy Markdown
Contributor

@sophietheking sophietheking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this PR and making this change. 💖 I'll update the branch and get this merged once tests are passing 🍏.

@MichealThabbet

This comment was marked as spam.

@sophietheking sophietheking added the ready to merge This pull request is ready to merge label Jan 26, 2023
@sophietheking sophietheking merged commit 17d2ea6 into github:main Jan 27, 2023
@github-actions
Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

authentication Content relating to authentication content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants